Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

doc: librpma discontinuation announcement #2137

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Sep 5, 2023

This change is Reviewable

@grom72 grom72 requested review from janekmi and osalyk September 5, 2023 13:09
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

Copy link

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)


README.md line 19 at r1 (raw file):

Intel no longer accepts patches to this project.
If you have an ongoing need to use this project, are interested in independently developing it, or would like to maintain patches for the open source software community, please create your own fork of this project.
You will find more information [here](https://pmem.io/blog/2022/11/update-on-pmdk-and-our-long-term-support-strategy/).

Can we apply this kind of formatting: https://github.com/pmem/libpmemobj-cpp?
Without it, the announcement is almost invisible.

Copy link

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @grom72)


.github/workflows/on_pull_request.yml line 34 at r2 (raw file):

                 "N=6 OS=rockylinux OS_VER=8  CC=gcc   PUSH_IMAGE=1",
                 # Ubuntu-latest with rdma-core v45.0 installed from sources
                 "N=7 OS=ubuntu OS_VER=latest-with-rdma-core-45 CC=gcc", # disabled intentionaly before project archiving: TESTS_COVERAGE=1",

Suggestion:

# TESTS_COVERAGE=1 disabled intentionally before project archiving

Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @janekmi and @osalyk)


README.md line 19 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

Can we apply this kind of formatting: https://github.com/pmem/libpmemobj-cpp?
Without it, the announcement is almost invisible.

Done.


.github/workflows/on_pull_request.yml line 34 at r2 (raw file):

                 "N=6 OS=rockylinux OS_VER=8  CC=gcc   PUSH_IMAGE=1",
                 # Ubuntu-latest with rdma-core v45.0 installed from sources
                 "N=7 OS=ubuntu OS_VER=latest-with-rdma-core-45 CC=gcc", # disabled intentionaly before project archiving: TESTS_COVERAGE=1",

Done.

Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @janekmi)

@grom72 grom72 force-pushed the discontinuation branch 2 times, most recently from bc7dd6c to 24f3b9f Compare September 5, 2023 13:59
Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @janekmi)

Copy link

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)

Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)

Copy link

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

@grom72 grom72 merged commit f52c00d into pmem:main Sep 5, 2023
11 checks passed
@grom72 grom72 deleted the discontinuation branch September 5, 2023 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants